Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Delete records #4930

Closed
sdiazlor opened this issue May 7, 2024 · 6 comments · Fixed by #4980
Closed

[FEAT] Delete records #4930

sdiazlor opened this issue May 7, 2024 · 6 comments · Fixed by #4980
Assignees
@sdiazlor
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK good first issue Indicates a good issue for first-time contributors
Milestone
v2.0.0

Comments

@sdiazlor
Copy link
Contributor

sdiazlor commented May 7, 2024

I would like to also have the possibility of deleting records.
@burtenshaw burtenshaw added the good first issue Indicates a good issue for first-time contributors label May 8, 2024
@sdiazlor sdiazlor self-assigned this May 23, 2024
@burtenshaw
Copy link
Contributor

@nataliaElv This is something we could feasibly fit into v2. Do you think it adds value?

@nataliaElv
Copy link
Member

Yes it does! 😃 I'll add it to the milestone

@burtenshaw
Copy link
Contributor

@sdiazlor

How do you plan on interfacing this feature? I first expected just a record delete method, like so:

for record in dataset.record:
    record.delete()

@burtenshaw
Copy link
Contributor

burtenshaw commented Jun 4, 2024 •
edited
Loading

@sdiazlor Are you still working on this? If not, I can take it on.

@sdiazlor
Copy link
Contributor Author

sdiazlor commented Jun 4, 2024

@burtenshaw Yes, I worked on this and have the changes locally. These days I was waiting for the code migration to create the PR in the main argilla repo and no more PRs here

@nataliaElv
Copy link
Member

I'm moving this issue to the v2.0.0 milestone in the argilla repo then! So @sdiazlor can link the PR

@nataliaElv nataliaElv transferred this issue from argilla-io/argilla-python Jun 4, 2024
@nataliaElv nataliaElv added this to the v2.0.0 milestone Jun 4, 2024
@burtenshaw burtenshaw added the area: python sdk Indicates that an issue or pull request is related to the Python SDK label Jun 5, 2024
@sdiazlor sdiazlor mentioned this issue Jun 7, 2024
Merged
13 tasks
@sdiazlor sdiazlor linked a pull request Jun 10, 2024 that will close this issue
feat: delete records #4980
Merged
13 tasks
sdiazlor added a commit that referenced this issue Jun 13, 2024
@sdiazlor @pre-commit-ci @davidberenstein1957
feat: delete records (#4980)
e7efb09 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Basic method to delete the records. Records are still ingested to be
validated, but I don't think we need to allow data structures in this
workflow.

Closes #4930 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] New feature (non-breaking change which adds functionality)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [ ] Test A
- [ ] Test B

**Checklist**

- [ ] I added relevant documentation
- [ ] I followed the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: David Berenstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdiazlor sdiazlor

Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK good first issue Indicates a good issue for first-time contributors
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

feat: delete records argilla-io/argilla
3 participants
@burtenshaw @nataliaElv @sdiazlor