Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active listeners for Feedback Dataset #4658

Closed
Tracked by #28
vmehta-cohere opened this issue Mar 14, 2024 · 7 comments
Closed
Tracked by #28

Active listeners for Feedback Dataset #4658

vmehta-cohere opened this issue Mar 14, 2024 · 7 comments
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) severity: minor Indicates that the issue isn't urgent or blocking status: stale Indicates that there is no activity on an issue or pull request team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: enhancement Indicates new feature requests
Milestone

Comments

@vmehta-cohere
Copy link

Is your feature request related to a problem? Please describe.
For feedback datasets, which carry the ability to carry complex labeling tasks, manual interactions to trigger training/evaluation can be a bottleneck for high frequency models.

Describe the solution you'd like
Active listeners for datasets in Argilla to trigger functions on submit, maybe an ability to ex. trigger on submitted 50/60 examples or 60/60 examples etc.

Copy link

dosubot bot commented Mar 14, 2024

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added area: ui Indicates that an issue or pull request is related to the User Interface (UI) severity: minor Indicates that the issue isn't urgent or blocking team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: enhancement Indicates new feature requests labels Mar 14, 2024
@fozziethebeat
Copy link

I also just encountered this problem and found it very surprising to find out that listeners only work with pre-built template datasets.

From what I could discover it's because /api/datasets endpoint only returns these pre-built template datasets and deep down listeners only check that endpoint.

Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the status: stale Indicates that there is no activity on an issue or pull request label Jul 17, 2024
Copy link

This issue was closed because it has been inactive for 30 days since being marked as stale.

@nataliaElv
Copy link
Member

Reopening, as we might still want to tackle this one.

@nataliaElv nataliaElv reopened this Aug 28, 2024
@github-actions github-actions bot removed the status: stale Indicates that there is no activity on an issue or pull request label Aug 29, 2024
frascuchon added a commit that referenced this issue Oct 8, 2024
# Description
<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that are required for this change. -->

This PR adds the `argilla.webhooks` module to work with webhooks from
the SDK. With the changes on this PR, users can easily create webhook
listeners using the python SDK. For example, listening changes can be
defined as follows:

```python
import argilla as rg


@rg.webhook_listener(events="response.updated")
async def on_response_updated(response: rg.UserResponse, **kwargs):
   ... # do your work 

@rg.webhook_listener(events=["dataset.created", "dataset.updated", "dataset.published"])
async def on_dataset_event(
    type: str,
    timestamp: datetime,
    dataset: rg.Dataset,
    **kwargs,
):
    print(f"Event type {type} at {timestamp}")
    print(dataset.settings)

```

You can find a fully basic example using webhooks
[here](https://github.com/argilla-io/argilla/tree/feat/argilla/working-with-webhooks/examples/webhooks/basic-webhooks)

This is still a draft PR and the final feature may change.


Refs: #4658

**Type of change**
<!-- Please delete options that are not relevant. Remember to title the
PR according to the type of change -->

- New feature (non-breaking change which adds functionality)

**How Has This Been Tested**
<!-- Please add some reference about how your feature has been tested.
-->

**Checklist**
<!-- Please go over the list and make sure you've taken everything into
account -->

- I added relevant documentation
- I followed the style guidelines of this project
- I did a self-review of my code
- I made corresponding changes to the documentation
- I confirm My changes generate no new warnings
- I have added tests that prove my fix is effective or that my feature
works
- I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: David Berenstein <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sara Han <[email protected]>
Co-authored-by: José Francisco Calvo <[email protected]>
Copy link

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the status: stale Indicates that there is no activity on an issue or pull request label Nov 27, 2024
@frascuchon frascuchon added this to the v2.5.0 milestone Nov 27, 2024
@frascuchon
Copy link
Member

Fixed in #5467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) severity: minor Indicates that the issue isn't urgent or blocking status: stale Indicates that there is no activity on an issue or pull request team: ml Indicates that the issue or pull request is owned by the Machine Learning (ML) team type: enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

4 participants