-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG-UI/UX] Filtering by vectors #4655
Comments
Hey @damianpumar! Great to see you diving into the depths of Argilla again. Hope you're ready for another adventure in bug squashing! 🐛🔨 Based on the context provided, it seems like you're encountering an issue with the "Filtering by vectors" feature in the Argilla platform. However, without the exact error message, it's difficult to pinpoint the exact problem. The "Filtering by vectors" feature allows users to filter datasets or records based on specific vector attributes. Each vector is uniquely identified by a combination of The structure and data type of The data that the "Filtering by vectors" feature is expected to handle includes Vector Settings, Feedback Records, Vector Values, and Operations on Vectors. There are known issues or bugs related to the "Filtering by vectors" feature in the Argilla platform. Specifically, the test case marked with To better assist you, could you please provide more details about the error you're encountering? Specifically, the exact error message and the steps to reproduce the error would be very helpful. This will allow us to understand the issue more clearly and provide a more accurate solution. For reference, here are the sources I used to gather this information:
Sources
|
Thanks @damianpumar!! I need to do some tests by I think the problem is because this specific record doesn't contain a vector with that name since vector values are optional, even if vector settings are defined. |
Yes! I understood, but I'm not sure if we should handle it or not, because I don't know if this is a SDK issue or we can handle it in the frontend side. Thanks! |
Proposal for the toast message:
|
Final message: |
…or (#4856) # Description An error is raised from backend when trying to find similar records when the vector is not defined for the used record. The error is fine but an additional attribute is needed on the front to support mapping that specific error to a translated message to the user. This PR adds a new custom error using `message` and `code` attributes to be rendered as a JSON response. Closes #4655 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) - [ ] Documentation update **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Modifying existents tests. **Checklist** - [ ] I added relevant documentation - [ ] follows the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) ## Frontend handling ![Argilla](https://github.com/argilla-io/argilla/assets/7398909/38123437-4d8b-4e7b-9de5-fabc46b6823e) --------- Co-authored-by: Damián Pumar <[email protected]>
Try to find a similar record I get this error.
Screen.Recording.2024-03-13.at.16.27.14.mov
The text was updated successfully, but these errors were encountered: