Skip to content

Commit

Permalink
fix: remove wrong alias and define argas as expected params
Browse files Browse the repository at this point in the history
  • Loading branch information
frascuchon committed Dec 4, 2024
1 parent 1a1825c commit ab7aa9a
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions argilla-server/src/argilla_server/_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ def configure_extra_pages(app: FastAPI):
@app.get("/share", include_in_schema=False)
async def share_page(
request: Request,
image: str = Query("share_image"),
dataset_name: str = Query("dataset_name"),
dataset_id: str = Query("dataset_id"),
share_image: str = Query(),
dataset_name: str = Query(),
dataset_id: str = Query(),
):
url = request.url

Check warning on line 69 in argilla-server/src/argilla_server/_app.py

View check run for this annotation

Codecov / codecov/patch

argilla-server/src/argilla_server/_app.py#L69

Added line #L69 was not covered by tests

Expand All @@ -79,7 +79,7 @@ async def share_page(
<meta property="og:title" content="{dataset_name}" />
<meta property="og:type" content="website" />
<meta property="og:url" content="{url}" />
<meta property="og:image" content="{image}" />
<meta property="og:image" content="{share_image}" />
<meta
property="og:description"
content="Contribute with this {dataset_name}"
Expand All @@ -94,15 +94,15 @@ async def share_page(
name="twitter:description"
content="Contribute with this {dataset_name}"
/>
<meta name="twitter:image" content="{dataset_name}" />
<meta name="twitter:image" content="{share_image}" />
<meta name="twitter:site" content="" />
<meta property="og:title" content="{dataset_name}" />
<meta
property="og:description"
content="Contribute with this {dataset_name}"
/>
<meta property="og:image" content="{image}" />
<meta property="og:image" content="{share_image}" />
<meta property="og:url" content="{url}" />
<meta property="og:type" content="article" />
</head>
Expand Down

0 comments on commit ab7aa9a

Please sign in to comment.