✨ Fix go to outside from settings.

argilla-io · Jun 18, 2024 · 29952ad · 29952ad
1 parent 0379aec
commit 29952ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/argilla-frontend/pages/dataset/_id/settings.vue b/argilla-frontend/pages/dataset/_id/settings.vue
@@ -42,6 +42,9 @@ export default {
   components: {
     InternalPage,
   },
+  beforeRouteLeave(to, from, next) {
+    this.goToOutside(next);
+  },
   setup() {
     return useDatasetSettingViewModel();
   },

diff --git a/argilla-frontend/pages/dataset/_id/useDatasetSettingViewModel.ts b/argilla-frontend/pages/dataset/_id/useDatasetSettingViewModel.ts
@@ -94,7 +94,7 @@ export const useDatasetSettingViewModel = () => {
     ];
   });
 
-  const onGoToDataset = () => {
+  const goToDataset = () => {
     if (routes.previousRouteMatchWith(datasetId)) return routes.goBack();
 
     routes.goToFeedbackTaskAnnotationPage(datasetId);
@@ -112,23 +112,23 @@ export const useDatasetSettingViewModel = () => {
     if (datasetSetting.isVectorsModified) return goToTab("vector");
   };
 
-  const goToDataset = () => {
+  const goToOutside = (next) => {
     if (datasetSetting.isModified) {
       return notification.notify({
         message: t("changes_no_submit"),
         buttonText: t("button.ignore_and_continue"),
         permanent: true,
         type: "warning",
         onClick() {
-          onGoToDataset();
+          next();
         },
         onClose() {
           goToTabWithModification();
         },
       });
     }
 
-    onGoToDataset();
+    next();
   };
 
   onBeforeMount(() => {
@@ -155,6 +155,7 @@ export const useDatasetSettingViewModel = () => {
     isAdminOrOwnerRole,
     datasetId,
     datasetSetting,
+    goToOutside,
     goToDataset,
   };
 };