Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: One button connector #139

Draft
wants to merge 95 commits into
base: develop
Choose a base branch
from
Draft

Feat: One button connector #139

wants to merge 95 commits into from

Conversation

Cussone
Copy link
Member

@Cussone Cussone commented Oct 10, 2024 •
edited
Loading

Issue / feature description

One button connector: Combining Argent X and Argent mobile under one connector

Changes

WIP - this branch will serve as a base branch, I'll take pieces of work on other branches and merge back here

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@Cussone
feat: add new UI elements
1b4066b
@Cussone
feat: add new 1 button connector WIP
6560d74
@Cussone
Merge branch 'refs/heads/feat/argent-one-button-connector' into feat/…
8f7dcea 
…argent-one-button-connector-ui
@Cussone
chore: install @argent/x-ui@next
bf9294e
@Cussone
chore: use tailwind styles generated from x-ui
2d26120
@Cussone
Merge pull request #138 from argentlabs/feat/argent-one-button-connec…
8ed021a 
…tor-ui

Feat: Argent one button connector UI
@Cussone
chore: delete redundant component
14267a7
@Cussone
chore: inherit color for svg icons
44ce0a5
@Cussone
chore: remove redundant component
110bbdf
@Cussone
fix: add missing tailwind's color tokens from x-ui
1202fa3
@Cussone
chore: improve button components
f743342
@Cussone
chore: rename component to more appropriate name
c777e5d
@Cussone
chore: improve button component
8612c92
@Cussone
fix: color
9039438
@Cussone
feat: add component for rendering icons
c57a8d8
@Cussone
chore: clean up and add missing functionality
fba46c4
@Cussone
fix: pass props and type downloadLinks
6ff294e
@Cussone
chore: replace QR with loader, handle click
7097abc
@Cussone
chore: pass props, adapt usage
cc797b7
@Cussone
chore: connect buttons to handlers
bb2c00a
@Cussone
chore: type wallets, pass props
3c43169
@Cussone
feat: programmatically show install extension section
d571de8
@Cussone
chore: improve method naming
e5eecf4
@Cussone
fix: adapt type external
61ef1f0
@Cussone
feat: create helpers for connectors
ea4008b
@Cussone
feat: adapt modal to new features
53d303e
@Cussone
feat: create modal helpers
015dff2
@Cussone
feat: handle new UI and only QR code approach
c743c6d
@Cussone
chore: add todos
b3ecb62
@Cussone
chore: update closeModal usage according to API change
35dfa0c
Cussone and others added 30 commits November 1, 2024 13:59
@Cussone
fix: logical error, destroy modal if resultType !== "wallet"
3c71667
@semantic-release-bot
chore(release): 2.4.0-beta.4 [skip ci]
e0669ce 
# [2.4.0-beta.4](v2.4.0-beta.3...v2.4.0-beta.4) (2024-11-01)

### Bug Fixes

* ignore ts error ([96c06e1](96c06e1))
* logical error with modal closing ([ff8305d](ff8305d))
* logical error, destroy modal if `resultType !== "wallet"` ([3c71667](3c71667))
* passing wrong theme to `DynamicIcon` ([5e7cef2](5e7cef2))
@Cussone
fix: add missing closeModalOld for the old way of usage
6457371
@Cussone
Merge pull request #152 from argentlabs/feat/argent-one-button-connec…
cefa3c2 
…tor-qa-fixes

Fix: Fixes after QA
@Cussone
Merge pull request #147 from argentlabs/feat/argent-one-button-connec…
6eb7435 
…tor-logic

Feat: Argent one button connector logic
@Cussone
chore: change Argent connector's constructor params
658fa46
@Cussone
fix: usage of Argent connector
0245904
@Cussone
chore: implement getLayout function on modal
3cd4421
@Cussone
chore: show failure layout only on connecting/qrCode layouts
093f637
@Cussone
chore: delete redundant component
4649369
@Cussone
refactor: remove redundant Layout prop
5279df0
@Cussone
refactor: generalize ArgentDownload component
225e391
@Cussone
refactor: implement changed ux, remove redundant logic
2378e18
@Cussone
Merge pull request #153 from argentlabs/refactor/improve-download-ux
e8de757 
Refactor: Improve download UX
@Cussone
Merge branch 'refs/heads/develop' into feat/argent-one-button-connector
959f42b 
# Conflicts:
#	.github/workflows/release.yml
#	package.json
#	src/connectors/injected/index.ts
#	src/helpers/defaultConnectors.ts
#	src/modal/Modal.svelte
@Cussone
chore: add missing type
1b88b33
@Cussone
chore: use Braavos instead of InjectedConnector
be04ce3
@Cussone
refactor: add Connector to ConnectOptionsWithConnectors.connectors
09da0e2
@Cussone
refactor: add missing Connector after changing connect signature
f063b2f
@Cussone
feat: add new approval layout
010f3fc
@Cussone
chore: add approval layout to modal
bac6372
@Cussone
chore: rename success component
440012c
@Cussone
fix: missing import, missing error
864d6e4
@Cussone
feat: add approval prop to Layout enum
960e17c
@Cussone
refactor: change timeout for closing modal
94f970d
@Cussone
refactor: remove old and redundant logic, integrate new approval modal
b47b23f
@Cussone
Merge pull request #154 from argentlabs/feat/approve-argent-mobile
3b2b33d 
Feat: Approve argent mobile
@Cussone
refactor: move navigator helpers to separate file
d7bc2d4
@Cussone
Merge branch 'refs/heads/develop' into feat/argent-one-button-connector
752baeb 
# Conflicts:
#	package.json
#	src/connectors/argent/argentMobile/index.ts
#	src/connectors/connector.ts
#	src/main.ts
@Cussone
fix: mobile connector bug
e991c89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cussone @semantic-release-bot