OpenMC MSBR model and data #165

yardasol · 2022-09-26T21:25:08Z

Summary of changes

This PR adds an MSBR model for use by OpenMC using the same parameters in the Serpent MSBR model.

This PR also adds a script to download and convert the ENDF/B VII.1 library to an ACE library for use by Serpent. This ACE library can also be converted to the HDF5 format used by OpenMC.

Finally, this PR makes some minor bug fixes to typos present in the process_j312.bash script

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

Associated Issues and PRs

Issue: none

Associated Developers

Dev: @munkm

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

…sbr-model

This reverts commit aaae55f.

…sbr-model

Serpent geometry

yardasol · 2022-11-10T16:39:07Z

@ZoeRichter I'd love your input on this.

the original model's material compositions did not match what is in the Robertson report. This commit fixes that for the OpenMC version of the model

ZoeRichter

Looks good overall! Normally I'd complain about the "c1", "c2", "c3", etc. variable names not being descriptive enough, but I think it's fine in this case because you set the long form names within the variables themselves.

ZoeRichter · 2022-11-16T20:19:36Z

examples/msbr/README.md

+Figure 3.3, pg 16
+
+Model features:
+- Simplified Zone IA (graphite element is idential Zone IIA in the model, does not match original paper spec)


small typo, "identical to Zone IIA"

Suggested change

- Simplified Zone IA (graphite element is idential Zone IIA in the model, does not match original paper spec)

- Simplified Zone IA (graphite element is identical Zone IIA in the model, does not match original paper spec)

Good catch!

ZoeRichter · 2022-11-16T20:21:37Z

examples/msbr/README.md

+
+Model features:
+- Simplified Zone IA (graphite element is idential Zone IIA in the model, does not match original paper spec)
+- Simplified Zone IIA (graphite element does not match the original spec)


Checking to make sure I understand this correctly: Zone IA is identical to Zone IIA in the model, and neither match the specifications of Zone IIA from the paper? Could you mention how you changed Zone IIA in your model, compared to the specs?

Checking to make sure I understand this correctly: Zone IA is identical to Zone IIA in the model, and neither match the specifications of Zone IIA from the paper?

I've been working on chapter 4 of my thesis which is a descriptin of the MSBR reference design, as well as the CSG model, and I've come to learn that this statement is actually incorrect. What is called "zone IA" in the model actually matches more closely in dimension to zone IB. I made a PR to adjust this, but failed to update the README.

Could you mention how you changed Zone IIA in your model, compared to the specs?

I plan to overhaul the README with a summary of Chapter 4 of my thesis once that chapter is complete. Stay tuned for this.

ZoeRichter · 2022-11-16T20:27:36Z

examples/msbr/README.md

+
+Missing from model:
+- Zone IB
+- Top part of core (filled with salt?)


What is in the top of the core in the model? Is it just salt?

This is the xz-cross section of the core. I'm not sure what to call that rectangular bit sitting on top of the "main" vessel, but it seems to be part of the core. This is what I was referring to.

ZoeRichter · 2022-11-16T20:56:02Z

examples/msbr/geometry/msbr_full.ini


 % ------ Vacuum cell
-cell 57  5  void -3
+cell 57  5  void



Just to check I'm reading the changes right - it looks like you've removed the outer void that surrounds the outside of the reactor?

That's not quite right. I've removed the surface that bounds the void cell (Universe 5). Universe 5 is only used in lattice elements in the main lattice, so having that universe bounded by a surface that is equivalent to the lattice element boundary is redundant. That's why i removed the bounding surface for Universe 5, since the lattice does the bounding instead.

ZoeRichter · 2022-11-16T20:59:21Z

examples/msbr/msbr_endfb71.serpent

+%set rfw 1 restart
+set inventory fuel all
+
+%set printm 1 0.0


for the settings you've commented out: are these things you anticipate needing again later, or can you remove them entirely?

These settings are present in the original serpent input (msbr.serpent)

ZoeRichter · 2022-11-16T21:00:26Z

examples/msbr/msbr_endfb71_main.json

+       "template_input_file_path": "./msbr_endfb71.serpent",
+       "npop": 50,
+       "active_cycles": 20,
+       "inactive_cycles": 20,


are these pop/active/inactive values just for testing? They seem very low.

Correct. They are so we make sure the model actually will run in saltproc (it doesn't right now as I detailed in issue #171)

examples/msbr/openmc_msbr_model.py

ZoeRichter · 2022-11-16T21:11:06Z

scripts/README.md

-The script in this directory downloads and processes the JEFF 
-3.1.2 cross section library -- as well as spontaneous and delayed fission neutron and
+The scripts in this directory downloads and processes cross sections data for
+use in Serpent and OpenMC


"The scripts in this directory download and process"

We need more testing before changing the base composition This reverts commit 0694808.

samgdotson · 2022-12-01T17:22:31Z

I think @ZoeRichter should handle merging this

ZoeRichter

I think It looks good to merge.

ZoeRichter · 2022-12-01T22:26:00Z

examples/msbr/geometry/msbr_full.ini

+cell 315  0    fuel -3004 3017 -3011                      % Lower plenum
+cell 307  0    hast -3006 3005 3015 -3013                 % Radial vessel
+cell 308  0    hast -3006 3013 -3014                      % Top vessel
+cell 309  0    hast -3006 -3015 3016                      % Bottom vessel
 cell 310  0    outside   3006  3016 -3014


These comments are very helpful :)

ZoeRichter · 2022-12-01T22:30:33Z

@samgdotson merging is still blocked because you requested changes - if these have been resolved, I think this PR is good to go, and I'll merge it.

yardasol · 2022-12-05T16:12:49Z

@samgdotson I think I addressed all of your changes

samgdotson

There are still some unanswered comments. Mostly, I want to know where all of these numbers come from -- some manner of scrutinizing the data -- rather than having them handed down from some higher power.
This might take the form of a README file for each example. A curious third party should be able to cross-reference the data from somewhere.

samgdotson · 2022-12-05T20:16:47Z

examples/msbr/openmc_msbr_model.py

+fuel.add_components({'Li7': 0.0787474673879085,
+                     'Be9': 0.0225566879138321,
+                     'F19': 0.454003012179284,
+                     'Th232': 0.435579130482336,
+                     'U233': 0.00911370203663893},


The associated data is in examples/msbr/mats/msbr_saltproc_prepr_comp.ini where the values are also hardcoded but have a different "key."

I still want to know why these numbers and where they came from. The file above does not have this information either.

samgdotson · 2022-12-05T20:17:21Z

examples/msbr/openmc_msbr_model.py

+    main.universes = [[v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, d, z, z, z, z, z, z, z, z, z, u, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, v, v, v, v, d, z, z, z, z, l, l, l, l, l, l, l, l, l, z, z, z, z, u, v, v, v, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, v, v, d, z, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, z, u, v, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v],


What is the shape you're trying to make here?

samgdotson · 2022-12-05T20:23:34Z

examples/msbr/openmc_msbr_model.py

+        "Am243": 212952778.98135212,
+        "Cm246": 220179493.9541502,
+        "U239": 196182721.4907133,
+        "Np239": 198519429.0542043,
+        "Th233": 185840570.73897627,
+        "Cf251": 223166396.6983342,
+        "Am242": 215146730.16368726,
+        "Cm245": 214624022.18345505,
+        "Cf254": 230600814.3619568,
+        "Am241": 211216798.63643932,
+        "Th232": 197108389.42449385,
+        "Cm240": 219583368.40646642,
+        "Th231": 186918512.14598972,
+        "Bk246": 224446497.874413,
+        "Cm247": 218956599.9139631,
+        "U238": 206851381.70909396,
+        "Bk250": 225432928.78068554,
+        "U230": 198841127.68309468,
+        "Cf249": 221434495.10716867,
+        "U234": 200632850.9958874,
+        "Cm250": 219425761.1783332,
+        "Th229": 192235847.44789958,
+        "Cm241": 219075406.6897822,
+        "Pu237": 210593272.23024797,
+        "Am240": 215272544.02927735,


Just reiterating that I don't love having raw numbers like this. Ideally it would read something like

if deplete: fiss_q = read_values() .... # or with open("data.pkl", "rb") as serp_data: fiss_q = serp_data.load()

It just seems unsustainable to me.

… their sources

samgdotson

It's nearly there!

samgdotson · 2022-12-05T22:24:24Z

examples/msbr/openmc_msbr_model.py

+fuel.add_components({'Li7': 0.0787474673879085,
+                     'Be9': 0.0225566879138321,
+                     'F19': 0.454003012179284,
+                     'Th232': 0.435579130482336,
+                     'U233': 0.00911370203663893},


The readme for your thesis or for saltproc? I don't see any references to your (unpublished?) thesis in the saltproc readme. Perhaps it's in another PR?

samgdotson · 2022-12-05T22:27:12Z

examples/msbr/openmc_msbr_model.py

+    main.universes = [[v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, d, z, z, z, z, z, z, z, z, z, u, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, v, v, v, v, d, z, z, z, z, l, l, l, l, l, l, l, l, l, z, z, z, z, u, v, v, v, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, v, v, d, z, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, z, u, v, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v, v],
+                      [v, v, v, v, v, v, d, z, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, l, z, u, v, v, v, v, v, v],


I think that's fine, then. I wanted to see the shape you were going for and maybe check for some typos. It's another one of those things where a small error could generate considerable confusion later on.

samgdotson

I missed your comment about the json earlier.

samgdotson

I'll approve this, although I hope future versions will have fewer hardcoded values. Data should ideally be read in from somewhere.

…sbr-model OpenMC MSBR model and data 6bac510

…mc-msbr-model OpenMC MSBR model and data 6bac510

yardasol and others added 8 commits September 26, 2022 16:21

add notebook and script to generate msbr openmc model

a9038a6

typo fixes in process_j312.bash

88c3d8d

remove redundant surfacs in openmc_model.py

a7c208f

add missing python files

ebcacc7

fix plot and settings generation

b6bf524

use only 900K in process_j312.bash

dd2a0e1

add additional xsdata scripts; update xsdata readme

46c0d25

add endfb71 library compatible msbr example

670538f

yardasol force-pushed the openmc-msbr-model branch from 3a1fde8 to 670538f Compare October 5, 2022 17:20

yardasol and others added 5 commits October 5, 2022 16:11

add endfb71 library compatible msbr example

3ede9a2

fix divergent openmc and serpent model

7cec6fb

Merge remote-tracking branch 'origin/openmc-msbr-model' into openmc-m…

452f06d

…sbr-model

reduce region complexities in openmc model

aaae55f

fix merge conflict

90f3142

yardasol force-pushed the openmc-msbr-model branch from 90f3142 to af46265 Compare October 19, 2022 02:49

yardasol and others added 5 commits October 18, 2022 21:53

fix merge conflict

af46265

Merge remote-tracking branch 'origin/openmc-msbr-model' into openmc-m…

493fe06

…sbr-model

optimize model (notebook only for now)

b198664

Revert "reduce region complexities in openmc model"

375a100

This reverts commit aaae55f.

add optimized model alongside serpent-idential model

4cf717e

yardasol force-pushed the openmc-msbr-model branch 3 times, most recently from 7afaf2f to d40074b Compare October 22, 2022 03:45

yardasol added 7 commits October 21, 2022 22:50

add optimized model alongside serpent-idential model

d40074b

Merge remote-tracking branch 'origin/openmc-msbr-model' into openmc-m…

2c4ab77

…sbr-model

fix missing control rods, smallest octader

95b58c5

remove unneeded outside cells and add missing cell descriptors in

c76c993

Serpent geometry

change plotting colors of Serpent model geometry

ca32120

remove unneeded files

29731c0

remove redundant surfaces Always

3375a0c

fix incorrect script name in scripts README

82df38e

fix openmc model material compositons

0694808

the original model's material compositions did not match what is in the Robertson report. This commit fixes that for the OpenMC version of the model

ZoeRichter reviewed Nov 16, 2022

View reviewed changes

yardasol force-pushed the openmc-msbr-model branch from d3d754f to 4f8ffd6 Compare November 17, 2022 19:02

yardasol and others added 2 commits November 17, 2022 13:07

IA elements are actually IB elements

4f8ffd6

Revert "fix openmc model material compositons"

70fdb62

We need more testing before changing the base composition This reverts commit 0694808.

yardasol force-pushed the openmc-msbr-model branch from cbe0ce5 to a9ae969 Compare November 18, 2022 17:34

yardasol added 4 commits November 18, 2022 11:39

add default values to shared_elem_geometry

a9ae969

Add stochastic volume calculation to openmc model

896f5ad

fix zone names in serpent model

4021cf5

fix control rod specs

6ee2f36

yardasol requested review from ZoeRichter and samgdotson December 1, 2022 16:26

fix READMEs

2aac957

ZoeRichter approved these changes Dec 1, 2022

View reviewed changes

samgdotson requested changes Dec 5, 2022

View reviewed changes

add machinery to obtain fission-q and depletion chain data files from…

c1a2dd2

… their sources

yardasol requested a review from samgdotson December 5, 2022 21:40

samgdotson reviewed Dec 5, 2022

View reviewed changes

yardasol requested a review from samgdotson December 5, 2022 23:02

samgdotson approved these changes Dec 6, 2022

View reviewed changes

samgdotson merged commit 6bac510 into arfc:master Dec 6, 2022

github-actions bot pushed a commit that referenced this pull request Dec 6, 2022

update docs at commit: Merge pull request #165 from yardasol/openmc-m…

f71fc19

…sbr-model OpenMC MSBR model and data 6bac510

github-actions bot pushed a commit to khurrumsaleem/saltproc that referenced this pull request Dec 7, 2022

update docs at commit: Merge pull request arfc#165 from yardasol/open…

493c6d1

…mc-msbr-model OpenMC MSBR model and data 6bac510

github-actions bot pushed a commit to yardasol/saltproc that referenced this pull request Dec 9, 2022

update docs at commit: Merge pull request arfc#165 from yardasol/open…

87b8817

…mc-msbr-model OpenMC MSBR model and data 6bac510

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenMC MSBR model and data #165

OpenMC MSBR model and data #165

yardasol commented Sep 26, 2022 •

edited

Loading

yardasol commented Nov 10, 2022

ZoeRichter left a comment

ZoeRichter Nov 16, 2022 •

edited by yardasol

Loading

yardasol Nov 17, 2022

ZoeRichter Nov 16, 2022

yardasol Nov 17, 2022

ZoeRichter Nov 16, 2022

yardasol Nov 17, 2022

ZoeRichter Nov 16, 2022

yardasol Nov 17, 2022

ZoeRichter Nov 16, 2022

yardasol Nov 17, 2022

ZoeRichter Nov 16, 2022

yardasol Nov 17, 2022

ZoeRichter Nov 16, 2022

samgdotson commented Dec 1, 2022

ZoeRichter left a comment

ZoeRichter Dec 1, 2022

ZoeRichter commented Dec 1, 2022

yardasol commented Dec 5, 2022

samgdotson left a comment

samgdotson Dec 5, 2022

samgdotson Dec 5, 2022

samgdotson Dec 5, 2022

samgdotson left a comment

samgdotson Dec 5, 2022

samgdotson Dec 5, 2022

samgdotson left a comment

samgdotson left a comment

	- Simplified Zone IA (graphite element is idential Zone IIA in the model, does not match original paper spec)
	- Simplified Zone IA (graphite element is identical Zone IIA in the model, does not match original paper spec)

OpenMC MSBR model and data #165

OpenMC MSBR model and data #165

Conversation

yardasol commented Sep 26, 2022 • edited Loading

Summary of changes

Types of changes

Required for Merging

Associated Issues and PRs

Associated Developers

Checklist for Reviewers

yardasol commented Nov 10, 2022

ZoeRichter left a comment

Choose a reason for hiding this comment

ZoeRichter Nov 16, 2022 • edited by yardasol Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samgdotson commented Dec 1, 2022

ZoeRichter left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZoeRichter commented Dec 1, 2022

yardasol commented Dec 5, 2022

samgdotson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samgdotson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samgdotson left a comment

Choose a reason for hiding this comment

samgdotson left a comment

Choose a reason for hiding this comment

yardasol commented Sep 26, 2022 •

edited

Loading

ZoeRichter Nov 16, 2022 •

edited by yardasol

Loading