Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded material temperatures #154

Closed
wants to merge 6 commits into from

Conversation

yardasol
Copy link
Contributor

@yardasol yardasol commented Apr 22, 2022

Summary of changes

This PR fixes material temperatures being hardcoded to 900K.

Specifcially, this PR:

  • Adds a new attribute of DepcodeSerpent, fix_dict, that tracks the values of the fix card for each material
  • Passes these values to the iteration material file instead of overwriting/dropping them

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Required for Merging

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change is a source code change
    • I have added/modified tests to cover my changes
    • I have explained why my change does not require new/modified tests
  • My change is a user-facing change
    • I have recorded my changes in the changelog for the upcoming release
  • My change is exclusively related to the repository (e.g. GitHub actions workflows, PR/issue templates, etc.)
    • I have verified or justified that my change will work as intended.
  • All new and existing tests passed.
    • CI tests pass
    • Local tests pass (including Serpent2 integration tests)

Associated Issues and PRs

Associated Developers

  • Dev: @

Checklist for Reviewers

Reviewers should use this link to get to the
Review Checklist before they begin their review.

…s iteration material files; fix the material temperature not being preseved
@pep8speaks
Copy link
Contributor

pep8speaks commented Apr 22, 2022

Hello @yardasol! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 252:80: E501 line too long (92 > 79 characters)
Line 258:26: W605 invalid escape sequence '\s'
Line 258:32: W605 invalid escape sequence '\s'
Line 258:47: W605 invalid escape sequence '\s'
Line 258:57: W605 invalid escape sequence '.'

Comment last updated at 2022-07-27 19:18:58 UTC

@yardasol
Copy link
Contributor Author

Superseded by #178

@yardasol yardasol closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fuel Material Temperature Hardcoded (maybe?) in saltproc_mat
2 participants