Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exit code 3 for errors, 1 for failures #115

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Use exit code 3 for errors, 1 for failures #115

merged 2 commits into from
Nov 3, 2023

Conversation

andrewbranch
Copy link
Collaborator

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 3, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 5dba9a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@arethetypeswrong/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

andrewbranch
andrewbranch commented Nov 3, 2023
View reviewed changes
packages/history/scripts/generateFull.ts
Comment on lines -32 to -33
"[email protected]", // Invalid gzip data
"[email protected]", // Invalid gzip data
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were fixed by #103

@jakebailey
Copy link
Contributor

jakebailey commented Nov 3, 2023 •
edited
Loading

Hello drive by reviewer here; I would suggest choosing something < 125; 126 and 127 are special codes in the shells (which I learned from https://git-scm.com/docs/git-bisect#_bisect_run), with 125 being bisect's "untestable".

@jakebailey
Copy link
Contributor

on second thought, it's 125 that's special, 126/127 are just errors to bisect, so, ignore me have a nice day

@andrewbranch
Copy link
Collaborator Author

I chose 127 because I feel like I’ve definitely seen it for errors, but the reason I’ve seen it is probably that it is special to shells https://tldp.org/LDP/abs/html/exitcodes.html. I’ll pick something else 😄

@andrewbranch andrewbranch changed the title Use exit code 127 for errors, 1 for failures Use exit code 3 for errors, 1 for failures Nov 3, 2023
@andrewbranch andrewbranch merged commit 3fae6b0 into main Nov 3, 2023
1 check passed
@andrewbranch andrewbranch deleted the error-exit-code branch November 3, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewbranch @jakebailey