feat(alita-core): 支持形如 <A x /> x这类无指的属性

affects: @areslabs/alita-core
areslabs · Feb 14, 2020 · ffbe802 · ffbe802
1 parent f06465f
commit ffbe802
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/alita-core/src/precheck/checkJSX.ts b/packages/alita-core/src/precheck/checkJSX.ts
@@ -270,7 +270,8 @@ export default function checkJSX(ast, filepath, rawCode) {
                 return
             }
 
-            if (path.node.value.type === 'JSXExpressionContainer'
+            if (path.node.value
+                && path.node.value.type === 'JSXExpressionContainer'
                 && path.node.value.expression
                 && path.node.value.expression.type === 'MemberExpression'
                 && path.node.value.expression.object.type === 'ThisExpression'
@@ -284,7 +285,8 @@ export default function checkJSX(ast, filepath, rawCode) {
 
 
             // this.xx.bind(this)
-            if (path.node.value.type === 'JSXExpressionContainer'
+            if (path.node.value
+                && path.node.value.type === 'JSXExpressionContainer'
                 && path.node.value.expression
                 && path.node.value.expression.type === 'CallExpression'
                 && path.node.value.expression.callee.type === 'MemberExpression'

diff --git a/packages/alita-core/src/tran/compPreHandle.js b/packages/alita-core/src/tran/compPreHandle.js
@@ -19,6 +19,8 @@ import * as t from "@babel/types"
  *
  * 3. 移除JSX里面的注释
  *
+ * 4. <A x/> ==>  <A x="true"/>
+ *
  * ...
  *
  * @param ast
@@ -78,6 +80,12 @@ export default function compPreHandle(ast, info) {
                 path.parentPath.remove()
                 return
             }
+
+            if (path.type === 'JSXAttribute'
+                && !path.node.value
+            ) {
+                path.node.value = t.stringLiteral('true')
+            }
         }
     })