fix #25: Support ARM64 and other platforms

[adamchalmers]

I've added unit tests, so hopefully this works :) If you approve this PR I would appreciate cutting a new release afterwards, as there's a number of projects which would like to run this on ARM.

[adamchalmers]

Hmm, don't merge this, it doesn't properly detect these platforms yet.

[adamchalmers]

Actually, my test wasn't actually running on those weird platforms, it was using cross-compilation. I think setup-protoc should probably let users override os.arch() and specify their own arch/plat in an optional Github Action input if they choose to. But I'll open a separate PR for that.

[adamchalmers]

@MatteoPologruto @per1234 Hi! Could I please get a review on this?

[alessio-perugini]

Thank you for your contribution! Do you mind addressing the change requested? We'd really like to merge this 🤓

[adamchalmers]

Of course, I applied all suggestions.

[adamchalmers]

I can't get the prettier check to pass, despite running npm format. I assume I need some particular version of prettier installed? Or some particular npm/node version?

[alessio-perugini]

I can't get the prettier check to pass, despite running npm format. I assume I need some particular version of prettier installed? Or some particular npm/node version?

Might be related to this:

    ["protoc-3.20.2-osx-x86_64.zip", "darwin", "x64"][
      ("protoc-3.20.2-osx-x86_64.zip", "darwin", "x64")
    ],

should be:

    ["protoc-3.20.2-osx-x86_64.zip", "darwin", "x64"],
    ["protoc-3.20.2-osx-x86_64.zip", "darwin", "x64"],

[adamchalmers]

OK, formatter fixed. BTW in your formatting example

    ["protoc-3.20.2-osx-x86_64.zip", "darwin", "x64"],
    ["protoc-3.20.2-osx-x86_64.zip", "darwin", "x64"],

those two are actually duplicates! So I deduplicated it.

All tests pass now.

[alessio-perugini]

LGTM! 🚀

[adamchalmers]

Nice! I can't merge until @per1234 changes their review status, or an admin merges this for me.

[alessio-perugini]

@adamchalmers we forgot to run npm run build. Can you run it and add the changes in a new commit? 🙏

[adamchalmers]

Done, I got one error from npm run build

$ npm run build

> [email protected] build
> tsc

node_modules/keyv/src/index.d.ts:60:32 - error TS2304: Cannot find name 'AsyncGenerator'.

60  iterator(namespace?: string): AsyncGenerator<any, void, any>;
                                  ~~~~~~~~~~~~~~


Found 1 error.

[alessio-perugini]

Done, I got one error from npm run build

$ npm run build

> [email protected] build
> tsc

node_modules/keyv/src/index.d.ts:60:32 - error TS2304: Cannot find name 'AsyncGenerator'.

60  iterator(namespace?: string): AsyncGenerator<any, void, any>;
                                  ~~~~~~~~~~~~~~


Found 1 error.

It was something related to typescript version. If you rebase this on master and run again npm run build we should fix the issue. We're almost there 💪

EDIT: Actually not needed as we're switching to ncc building. Thank you so much for your contribution! 🥇

Requests for changes correctly submitted. 💪

[adamchalmers]

Awesome, thanks for shepherding this through, Alessio.