Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name of "AvrFHT" #4978

Open
wants to merge 1 commit into
base: production
Choose a base branch
from
Open

Update name of "AvrFHT" #4978

wants to merge 1 commit into from

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 13, 2024

Resolves #4977

@per1234 per1234 added topic: rename Change registered library name status: pending backend Depends on backend maintenance operations labels Aug 13, 2024
umbynos
umbynos reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I got from the backend @per1234:

2024/08/13 10:48:56 Loaded 7234 libraries from DB
error: Library name AVR FHT Library not found

But by looking in the gitclones folder the lib seems to be already updated with this change.. What should I do?

@umbynos umbynos added the status: waiting for information More information must be provided before work can proceed label Aug 13, 2024
@umbynos
Copy link
Contributor

umbynos commented Aug 13, 2024

And this is what I see from the logs of the latest run:

2024/08/13 10:37:11 Scraping https://github.com/KobaProduction/AvrFHT.git
2024/08/13 10:37:11 Checking out tag: v1.1.1
2024/08/13 10:37:11 Release AvrFHT:1.1.1 has wrong library name, should be AVR FHT Library

@per1234 per1234 mentioned this pull request Nov 5, 2024
Closed
@ArthurKoba
Copy link
Contributor

Hi @umbynos, can you go back to solving my problem and try to make corrections? Today I tried to delete the repository in order to add it again, but the request was rejected due to internal regulations. However, the presence of regulations does not solve the problem, but aggravates it. Isn't it easier to actually remove and add the library again than to waste both your and my time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos left review comments

Assignees
No one assigned
Labels
status: pending backend Depends on backend maintenance operations status: waiting for information More information must be provided before work can proceed topic: rename Change registered library name
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@per1234 @umbynos @ArthurKoba