Add release workflow and complementary files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release Example |
umbynos
force-pushed
the
umbynos/add_workflow
branch
from
dc6552f to
4155b72
Compare
0009 is used to patch cryptography version used because of: healthchecks/healthchecks#565
[TODO] remove hardcoded version and use ${GITHUB_REF/refs\/tags\//}
add bash as default shell to find zip on win
use 7zip on win to archive, zip is not installed by default
remove ${{ github.workspace }} from win, it does not get expanded correctly
tar in macos is not working correctly on the ghactions hosted runners actions/runner-images#2619
umbynos
force-pushed
the
umbynos/add_workflow
branch
from
4155b72 to
c5a94da
Compare
rsora
reviewed
Feb 16, 2022
…e for armv6. arm32v6 arch should be able to run arm32v5 binaries
…r and not from `imgtool/` one. Otherwise it will pick up the wrong main.py
umbynos
force-pushed
the
umbynos/add_workflow
branch
from
c5a94da to
4483ec0
Compare
per1234
requested changes
Feb 16, 2022
per1234
requested changes
Feb 16, 2022
per1234
requested changes
Feb 17, 2022
umbynos
force-pushed
the
umbynos/add_workflow
branch
from
640fb48 to
584c2ab
Compare
Co-authored-by: per1234 <[email protected]>
Co-authored-by: per1234 <[email protected]>
umbynos
force-pushed
the
umbynos/add_workflow
branch
from
1ce15ed to
2961b14
Compare
per1234
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Great work Umberto!
The other idea I had was to use the build script in the build job to make the system easier to maintain by avoiding code duplication between the two jobs. However, I found that it was difficult to achieve compatibility of the script in all platforms, so I gave up on the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR I'm adding:
release.ymlwhich is the release workflow to publish compiled imgtool version 1.8.0 to the release section here on GitHub and on the Arduino download servers. The workflow uses pyinstaller to generate an executable from a python project. The workflow leverage native compilation for win, macos, linux64. The binaries for the other platforms (linux32, linux-armv6, linux-armv7, linux-arm64) are built using crosscompilation, qemu, and docker containers.patches/it's a folder containing all the patches generated by us hereREADME.mdwith general info regarding the repo and imgtool