Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing i18n for UI strings #1341

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Add missing i18n for UI strings #1341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb44f47
Add missing i18n for UI strings
per1234 Aug 21, 2022
d250a17
Fix inconsistency of input field placeholder text capitalization
per1234 Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions arduino-ide-extension/src/browser/boards/boards-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,10 @@ export class BoardsConfig extends React.Component<
type="search"
value={query}
className="theia-input"
placeholder="SEARCH BOARD"
placeholder={nls.localize(
'arduino/board/searchBoard',
'SEARCH BOARD'
per1234 marked this conversation as resolved.
Show resolved Hide resolved
)}
onChange={this.updateBoards}
ref={this.focusNodeSet}
/>
Expand Down Expand Up @@ -344,7 +347,9 @@ export class BoardsConfig extends React.Component<
});
}
return !ports.length ? (
<div className="loading noselect">No ports discovered</div>
<div className="loading noselect">
{nls.localize('arduino/board/noPortsDiscovered', 'No ports discovered')}
</div>
) : (
<div className="ports list">
{ports.map((port) => (
Expand Down
6 changes: 5 additions & 1 deletion arduino-ide-extension/src/browser/dialogs/user-fields/user-fields-component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,11 @@ export const UserFieldsComponent = ({
type={field.secret ? 'password' : 'text'}
value={field.value}
className="theia-input"
placeholder={'Enter ' + field.label}
placeholder={nls.localize(
'arduino/userFields/enterField',
'Enter {0}',
field.label
)}
onChange={updateUserField(index)}
/>
</div>
Expand Down
6 changes: 5 additions & 1 deletion arduino-ide-extension/src/node/boards-service-impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
} from './cli-protocol/cc/arduino/cli/commands/v1/upload_pb';
import { ExecuteWithProgress } from './grpc-progressible';
import { ServiceError } from './service-error';
import { nls } from '@theia/core/lib/common';

@injectable()
export class BoardsServiceImpl
Expand Down Expand Up @@ -319,7 +320,10 @@ export class BoardsServiceImpl
.join(', '),
installable: true,
deprecated: platform.getDeprecated(),
summary: 'Boards included in this package:',
summary: nls.localize(
'arduino/component/boardsIncluded',
'Boards included in this package:'
),
installedVersion,
boards: platform
.getBoardsList()
Expand Down
4 changes: 4 additions & 0 deletions i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"installManually": "Install Manually",
"installNow": "The \"{0} {1}\" core has to be installed for the currently selected \"{2}\" board. Do you want to install it now?",
"noFQBN": "The FQBN is not available for the selected board \"{0}\". Do you have the corresponding core installed?",
"noPortsDiscovered": "No ports discovered",
"noPortsSelected": "No ports selected for board: '{0}'.",
"noneSelected": "No boards selected.",
"openBoardsConfig": "Select other board and port…",
Expand All @@ -26,6 +27,7 @@
"portLabel": "Port: {0}",
"programmer": "Programmer",
"reselectLater": "Reselect later",
"searchBoard": "SEARCH BOARD",
"selectBoard": "Select Board",
"selectBoardForInfo": "Please select a board to obtain board info.",
"selectPortForInfo": "Please select a port to obtain board info.",
Expand Down Expand Up @@ -115,6 +117,7 @@
"error": "Compilation error: {0}"
},
"component": {
"boardsIncluded": "Boards included in this package:",
"by": "by",
"filterSearch": "Filter your search...",
"install": "INSTALL",
Expand Down Expand Up @@ -344,6 +347,7 @@
},
"userFields": {
"cancel": "Cancel",
"enterField": "Enter {0}",
"upload": "Upload"
}
},
Expand Down