#1014 Cleaned up File menu.
#1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed: - `New File`, - `New Window`. Closes #1014. Signed-off-by: Akos Kitta <[email protected]>
3 tasks
francescospissu
approved these changes
Jun 17, 2022
per1234
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
There was some interest in the "New Window" feature:
- https://forum.arduino.cc/t/unable-to-open-multiple-sessions-on-the-same-sketch/920159
- https://forum.arduino.cc/t/ide2-rc5-2-instances-of-ide-on-same-project-with-2-boards-connected/968067
- Restrict the app to one instance #114 (comment)
- Allow one sketch to be uploaded to, and serial-monitored on, multiple ports #583 (comment)
However, it was not a lot and the fact that nobody report it breaking in 2.0.0-rc7 indicates to me that there is no use of it.
I'm always in favor of avoiding unnecessary complexity in the Arduino IDE and so it seems that, even working, the harm probably outweighed the benefits. And certainly in a non-functional state there was only harm to it.
I'm very glad to see the "New File" menu item removed.
Thanks Akos!
per1234
added
topic: code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Removed the following items from the
Filemenu:New File,New Window.Change description
Other information
I was there, so I removed
New Window. It did not work and we never wanted to have such a menu item.Before:
After:
Reviewer checklist