Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bound the original handler to this. #1057

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Bound the original handler to this. #1057

merged 1 commit into from
Jun 14, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Jun 13, 2022 •
edited
Loading

Motivation

To fix the error that occurred on every click in the IDE2.

Change description

bind the original function to this.

Other information

It still should not be possible to drag and drop widgets.

How to verify the fix:

  • Start the IDE2,
  • Open dev tools (Ctrl+Alt+I on Windows and Option+Cmd+I on macOS),
  • Click in the editor, Output view, anywhere. You are expected to not see the cannot read properties of undefined (reading '_evtMouseDown') error. If you do not know how to reproduce the defect, please check An error is thrown when I click in the editor, or output view #977 for inspiration.

Closes #977

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Bound the original handler to this.
b806bcf 
Closes #977

Signed-off-by: Akos Kitta <[email protected]>
francescospissu
francescospissu approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@francescospissu francescospissu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the change and it now works as expected. No more errors are thrown when clicking anywhere in the IDE.

Arduino IDE version

2.0.0-rc7-snapshot-f30fa8e

Operating system

Windows 11

@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jun 14, 2022
@kittaakos kittaakos merged commit a9aac0d into main Jun 14, 2022
@kittaakos kittaakos deleted the #977 branch June 14, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescospissu francescospissu francescospissu approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An error is thrown when I click in the editor, or output view
3 participants
@kittaakos @francescospissu @per1234