-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Survey notification implementation #1035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
reviewed
Jun 10, 2022
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Jun 11, 2022
francescospissu
force-pushed
the
fspissu/survey-notification
branch
from
June 13, 2022 16:06
52c1221
to
61b8b8c
Compare
AlbyIanna
reviewed
Jun 14, 2022
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
per1234
previously requested changes
Jun 14, 2022
arduino-ide-extension/src/browser/contributions/survey-notification.ts
Outdated
Show resolved
Hide resolved
kittaakos
approved these changes
Jun 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice code 😍 Thank you!
francescospissu
force-pushed
the
fspissu/survey-notification
branch
from
June 16, 2022 16:30
226f0b8
to
77698f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A survey is needed to investigate the motivation, ability and context of use of the IDE 2 by users.
Change description
A notification box has been implemented with a button to redirect to the survey and another to reject it.
Reviewer checklist