Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled MenuItem roles on macOS. #1022

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Disabled MenuItem roles on macOS. #1022

merged 1 commit into from
Jun 22, 2022

Conversation

kittaakos
Copy link
Contributor

Motivation

The MenuItem#role support is broken in Theia. This PR disables the role and falls back to the default, command-based execution on click.

Change description

Disabled the role support on macOS.

Other information

This issue must be macOS-specific and should be verified by a macOS user.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Closes #969
Upstream-ref: eclipse-theia/theia#11217

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added topic: code Related to content of the project itself os: macos Specific to macOS operating system type: imperfection Perceived defect in any part of project labels Jun 8, 2022
@kittaakos
Copy link
Contributor Author

@ubidefeo, please verify if you have some time. Thank you!

@ubidefeo
Copy link

I tested this build.
The first Undo operation is ignored.

If I add 3 new lines anywhere, the first time I select Edit > Undo nothing happens.
Subsequent clicks undo the edit

@kittaakos
Copy link
Contributor Author

Thank you for the review, @ubidefeo.

This PR is intended to fix Menu item "Edit > Select All" only select 10 lines of code #969.

However, I can confirm that Edit > Undo does not work in IDE2. Undo does not work with the latest 2.0.0-rc7, and it does not work in Theia either.

@ubidefeo
Copy link

@kittaakos
now I see why I tested "Undo": it's mentioned in the Theia issue linked above.
I did not make it up to be related to the one I reported (#969 )

Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kittaakos kittaakos merged commit 0f8a29a into main Jun 22, 2022
@kittaakos kittaakos deleted the #969 branch June 22, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants