Let CSS do the uppercase transformation.

Expose no implementation details to translation files. Signed-off-by: Akos Kitta <[email protected]>
arduino · Oct 19, 2022 · 87ebcbe · 87ebcbe
1 parent 99b1094
commit 87ebcbe
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 13 deletions.
diff --git a/arduino-ide-extension/src/browser/style/index.css b/arduino-ide-extension/src/browser/style/index.css
@@ -137,6 +137,9 @@ button.secondary[disabled], .theia-button.secondary[disabled] {
   font-size: 14px;
 }
 
+.uppercase {
+  text-transform: uppercase;
+}
 
 /* High Contrast Theme rules */
 /* TODO: Remove it when the Theia version is upgraded to 1.27.0 and use Theia APIs to implement it*/

diff --git a/arduino-ide-extension/src/browser/style/list-widget.css b/arduino-ide-extension/src/browser/style/list-widget.css
@@ -112,14 +112,12 @@
     max-height: calc(1em + 4px);
     color: var(--theia-button-foreground);
     content: attr(install);
-    text-transform: uppercase;
 }
 
 .component-list-item .header .installed:hover:before {
     background-color: var(--theia-button-foreground);
     color: var(--theia-button-background);
     content: attr(uninstall);
-    text-transform: uppercase;
 }
 
 .component-list-item[min-width~="170px"] .footer {

diff --git a/arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-widget.tsx b/arduino-ide-extension/src/browser/widgets/cloud-sketchbook/cloud-sketchbook-tree-widget.tsx
@@ -61,10 +61,10 @@ export class CloudSketchbookTreeWidget extends SketchbookTreeWidget {
           </div>
         </div>
         <button
-          className="theia-button"
+          className="theia-button uppercase"
           onClick={() => shell.openExternal('https://create.arduino.cc/editor')}
         >
-          {nls.localize('cloud/GoToCloud', 'GO TO CLOUD')}
+          {nls.localize('arduino/cloud/goToCloud', 'Go to Cloud')}
         </button>
         <div className="center item"></div>
       </div>

diff --git a/arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx b/arduino-ide-extension/src/browser/widgets/component-list/list-item-renderer.tsx
@@ -56,10 +56,10 @@ export class ListItemRenderer<T extends ArduinoComponent> {
           )}
         </span>
         <span
-          className="installed"
+          className="installed uppercase"
           onClick={onClickUninstall}
           {...{
-            install: nls.localize('arduino/component/installed', 'INSTALLED'),
+            install: nls.localize('arduino/component/installed', 'Installed'),
             uninstall: nls.localize('arduino/component/uninstall', 'Uninstall'),
           }}
         />
@@ -77,10 +77,10 @@ export class ListItemRenderer<T extends ArduinoComponent> {
     const onClickInstall = () => install(item);
     const installButton = item.installable && (
       <button
-        className="theia-button secondary install"
+        className="theia-button secondary install uppercase"
         onClick={onClickInstall}
       >
-        {nls.localize('arduino/component/install', 'INSTALL')}
+        {nls.localize('arduino/component/install', 'Install')}
       </button>
     );
 

diff --git a/i18n/en.json b/i18n/en.json
@@ -90,6 +90,7 @@
       "donePushing": "Done pushing ‘{0}’.",
       "embed": "Embed:",
       "emptySketchbook": "Your Sketchbook is empty",
+      "goToCloud": "Go to Cloud",
       "learnMore": "Learn more",
       "link": "Link:",
       "notYetPulled": "Cannot push to Cloud. It is not yet pulled.",
@@ -144,8 +145,8 @@
       "boardsIncluded": "Boards included in this package:",
       "by": "by",
       "filterSearch": "Filter your search...",
-      "install": "INSTALL",
-      "installed": "INSTALLED",
+      "install": "Install",
+      "installed": "Installed",
       "moreInfo": "More info",
       "uninstall": "Uninstall",
       "uninstallMsg": "Do you want to uninstall {0}?",
@@ -422,9 +423,6 @@
       "upload": "Upload"
     }
   },
-  "cloud": {
-    "GoToCloud": "GO TO CLOUD"
-  },
   "theia": {
     "core": {
       "cannotConnectBackend": "Cannot connect to the backend.",