Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for 'board details' command #924

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 26, 2020

The NPE is triggered if Platform.Resource is nil (this may happen forplatforms installed manually in the sketchbook/hardware directory for example).

Related to #759

@matthijskooijman @fpistm @a7hybnj2

The NPI is triggered if Platform.Resource is nil (this may happen for
platforms installed manually in the sketchbook/hardware directory for
example).

Related to arduino#759
Copy link
Collaborator

@matthijskooijman matthijskooijman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just tested this for adafruit:samd:adafruit_feather_m0 and STM32:stm32:Nucleo_64 and works like expected. Thanks!

@cmaglie cmaglie merged commit 6fb6405 into arduino:master Aug 27, 2020
@cmaglie cmaglie changed the title Fix NPE for 'board install' command Fix NPE for 'board details' command Aug 27, 2020
@cmaglie cmaglie deleted the fix_board_details_for_manually_added_platforms branch August 27, 2020 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants