Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow post_install for untrusted platforms #911

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Allow post_install for untrusted platforms #911

merged 1 commit into from
Aug 20, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 20, 2020

Follows #893 (comment)

Does it really add anything to add an isTrusted flag here? AFAICS, an "untrusted" platform can still provide custom compiler binaries and compiler commands in platform.txt, so this trusted flag would only prevent running untrusted code at platform install time, as soon as you actually use the platform to compile a sketch, untrusted code will be ran in any case?

/cc @luigigubello @rsora

rsora
rsora approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will address the concept of "Trusted Platform" in the near future.

@rsora rsora merged commit 45b2421 into arduino:master Aug 20, 2020
@cmaglie cmaglie deleted the allow_3rd_party_postinstall branch August 20, 2020 12:30
@per1234 per1234 mentioned this pull request Sep 10, 2020
Merged
4 tasks
@per1234 per1234 mentioned this pull request Jan 21, 2022
Closed
@per1234 per1234 mentioned this pull request Feb 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora