Fix zsh completion #892
Merged
Fix zsh completion #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
force-pushed
the
fix_zsh_completion
branch
from
330a659 to
15a071a
Compare
umbynos
force-pushed
the
fix_zsh_completion
branch
from
15a071a to
98d6387
Compare
silvanocerza
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Bugfix/enhancement
Zsh completion was not showing file completion when no other completion was available
fix the above-mentioned issue
add support also for
--no-descriptionflag for zsh completionfix this hack functions in fish shell completion auto-generated file should not contain "-" character spf13/cobra#1121
Does this PR introduce a breaking change?
no
I had to update cobra to a non-release version for spf13/cobra#1070 PR and spf13/cobra#1122 which fixes also this issue spf13/cobra#1121. Cobra guys seem slow in approving PR/making new releases
See how to contribute