Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zsh completion #892

Merged
merged 5 commits into from
Aug 10, 2020
Merged

Fix zsh completion #892

merged 5 commits into from
Aug 10, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Aug 10, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Bugfix/enhancement

  • What is the current behavior?

Zsh completion was not showing file completion when no other completion was available

  • What is the new behavior?

no

  • Other information:

I had to update cobra to a non-release version for spf13/cobra#1070 PR and spf13/cobra#1122 which fixes also this issue spf13/cobra#1121. Cobra guys seem slow in approving PR/making new releases


See how to contribute

@umbynos umbynos requested a review from a team August 10, 2020 11:04
@umbynos umbynos merged commit 82df01f into master Aug 10, 2020
@umbynos umbynos deleted the fix_zsh_completion branch August 10, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants