Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ARDUINO_LIB_DISCOVERY_PHASE automatic flag incompatiblity #838

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Fix ARDUINO_LIB_DISCOVERY_PHASE automatic flag incompatiblity #838

merged 2 commits into from
Jul 23, 2020

Commits on Jul 17, 2020

  1. Revert "Add macro -DARDUINO_LIB_DISCOVERY_PHASE during lib discovery … 

    …phase (arduino#633)"

This reverts commit 985b2c9.
    @cmaglie
    cmaglie committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    740aecf View commit details
    Browse the repository at this point in the history

  2. Set {build.library_discovery_phase} to 1 during lib discovery 

    Previously we used to add `-DARDUINO_LIB_DISCOVERY_PHASE` to the gcc
command line but this produced some incompatiblity with compilers using
non-standard `-d` flag instead of `-D`:

arduino#633 (comment)
    @cmaglie
    cmaglie committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    e0e367b View commit details
    Browse the repository at this point in the history