Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serial port URI parsing in board attach command #661

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Apr 16, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • The PR follows our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce?

Fixes bug on windows related to board attach command

  • What is the current behavior?

The message

Attach board error: no supported board found at serial://COM7

is returned even if a board is attached to COM7 port

C:\Users\umber\Downloads\empty>..\arduino-cli.exe board list
Port Type              Board Name            FQBN                     Core         
COM3 Serial Port       Unknown
COM4 Serial Port       Unknown
COM7 Serial Port (USB) Arduino MKR WiFi 1010 arduino:samd:mkrwifi1010 arduino:samd
  • What is the new behavior?
  • Does this PR introduce a breaking change?
  • Other information:

There is already an integration test that uses board attach command


See how to contribute

@rsora rsora merged commit 780a04a into master Apr 16, 2020
@rsora rsora deleted the rsora/attach-fix-win branch April 16, 2020 14:08
@rsora rsora added the kind/bug label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants