Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Improved progress report from Compile #625

Merged
merged 3 commits into from
Mar 18, 2020

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Mar 18, 2020

This PR fix the progress reporting from the builder that was totally wrong.
This patch partially includes https://github.com/arduino/arduino-builder/pull/289/files.

Fix arduino/arduino-builder#289
Fix arduino/Arduino#7138

This will help for a better progress management in a next commit since
now we know in advance how many file will be compiled in this task.
@cmaglie cmaglie added this to the 0.10.0 milestone Mar 18, 2020
@cmaglie cmaglie requested a review from facchinm March 18, 2020 10:43
@cmaglie cmaglie self-assigned this Mar 18, 2020
@facchinm
Copy link
Member

Looks wonderful 🚀

@cmaglie cmaglie merged commit 0866d99 into arduino:master Mar 18, 2020
@cmaglie cmaglie deleted the improved-progress branch March 18, 2020 11:12
cmaglie added a commit to arduino/arduino-builder that referenced this pull request Mar 18, 2020
- Improved build progress reports:
  arduino/arduino-cli#625
cmaglie added a commit to arduino/arduino-builder that referenced this pull request Jun 12, 2020
- Removed automatic '--relax' hack for compiles on Atmega2560 MCU
  arduino/arduino-cli#749

- Fixed skethbook+bootloader hex merger.
  arduino/arduino-cli#744

- Fixed race condition in legacy i18n.LoggerToCustomStreams
  arduino/arduino-cli#704

- Fixed path-relativization error when traversing different partitions
  arduino/arduino-cli#658

- Add macro during lib discovery phase
  arduino/arduino-cli#633

- legacy: Improved progress report from Compile
  arduino/arduino-cli#625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling Sketch Progress Bar is Ineffective
2 participants