Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option --dest-dir to config init, removed noop --save-as #575

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

masci
Copy link
Contributor

@masci masci commented Feb 4, 2020

The option --save-as to the command config init is a no-op and has been removed.

A new option --dest-dir was added that can be used to specify a destination folder where to put the configuration file.

Fixes #570

@masci masci added this to the 0.8.0 milestone Feb 4, 2020
@kittaakos
Copy link
Contributor

I have verified it locally, and it works as expected. ✨

akos.kitta@Akoss-MacBook-Pro arduino-cli % pwd
/Users/akos.kitta/git/arduino-cli
akos.kitta@Akoss-MacBook-Pro arduino-cli % rm -rf ~/Library/Arduino15 && rm -rf ~/Documents/Arduino
akos.kitta@Akoss-MacBook-Pro arduino-cli % git rev-parse --short HEAD                              
5c21c083
akos.kitta@Akoss-MacBook-Pro arduino-cli % ./arduino-cli version                                   
arduino-cli Version: 0.0.0-git Commit: 
akos.kitta@Akoss-MacBook-Pro arduino-cli % ./arduino-cli config init --dest-dir ~/Desktop          
Config file written to: /Users/akos.kitta/Desktop/arduino-cli.yaml
akos.kitta@Akoss-MacBook-Pro arduino-cli % cat ~/Desktop/arduino-cli.yaml 
board_manager:
  additional_urls: []
daemon:
  port: "50051"
directories:
  data: /Users/akos.kitta/Library/Arduino15
  downloads: /Users/akos.kitta/Library/Arduino15/staging
  user: /Users/akos.kitta/Documents/Arduino
logging:
  file: ""
  format: text
  level: info
akos.kitta@Akoss-MacBook-Pro arduino-cli % cd ~/Desktop/foo
cd: no such file or directory: /Users/akos.kitta/Desktop/foo
akos.kitta@Akoss-MacBook-Pro arduino-cli % ./arduino-cli config init --dest-dir ~/Desktop/foo
Config file written to: /Users/akos.kitta/Desktop/foo/arduino-cli.yaml
akos.kitta@Akoss-MacBook-Pro arduino-cli % cat ~/Desktop/foo/arduino-cli.yaml                
board_manager:
  additional_urls: []
daemon:
  port: "50051"
directories:
  data: /Users/akos.kitta/Library/Arduino15
  downloads: /Users/akos.kitta/Library/Arduino15/staging
  user: /Users/akos.kitta/Documents/Arduino
logging:
  file: ""
  format: text
  level: info
akos.kitta@Akoss-MacBook-Pro arduino-cli % 

Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rsora rsora merged commit 553b7be into master Feb 11, 2020
@rsora rsora deleted the massi/config-init branch February 11, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config init ignores the --save-as flag
3 participants