Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache clean command #560

Merged
merged 3 commits into from
Feb 4, 2020
Merged

Add cache clean command #560

merged 3 commits into from
Feb 4, 2020

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Jan 18, 2020

Add command cache clean to clean the cache files
depending on the loaction of the caching files
under different OS.

Relates #285

@howjmay
Copy link
Contributor Author

howjmay commented Jan 18, 2020

I should appending test case in this PR right?

@howjmay howjmay force-pushed the cache_clean branch 3 times, most recently from f31958e to c8b1d9b Compare January 18, 2020 13:54
cli/cache/clean.go Outdated Show resolved Hide resolved
@masci masci changed the title feat: Add cache clean Add cache clean command Jan 20, 2020
@masci masci added this to the 0.8.0 milestone Jan 20, 2020
@howjmay
Copy link
Contributor Author

howjmay commented Jan 30, 2020

Fixed it

howjmay and others added 3 commits February 4, 2020 15:42
Add command `cache clean` to clean the cache files
depending on the loaction of the caching files
under different OS.
Clean cache files with command `arduino-cli cache clean`.
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated.
I've simplified a bit the logic of the tests leveraging pytest fixtures, other than that LGTM!

@masci masci merged commit 947e792 into arduino:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants