Fix regression on compile and upload with attached sketches #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
pushed a commit
that referenced
this pull request
Jan 8, 2020
* fix regression on board attach * fix integration tests
|
Hi @masci, I had opened another PR which produces a nice CLI message and handles attached sketches correctly. Let me know if you are still interested in it. |
|
@federicobond go for it, I needed a quick fix to address the regression but I'll be happy to merge a more comprehensive solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In attempt to improve the error messages we merged #523 but this broke the
compileandattachcommands, complaining for missing FQBN even for sketches that have been previously attached.Side note, since we merged #536, the error messages with this PR will be ok even with #523 partially reverted.