Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] check if PackagesDir exists when reporting it in HardwareDirectories() #533

Merged

Conversation

phd
Copy link
Contributor

@phd phd commented Dec 28, 2019

Fix error on arduino-cli core update-index with nonexistent ".arduino15" dir:
"Error initializing package manager: cannot initialize package manager: loading hardware packages: loading hardware from /.../.arduino15/packages: /.../.arduino15/packages is not a directory"

@phd
Copy link
Contributor Author

phd commented Dec 28, 2019

Fixes #529

@masci
Copy link
Contributor

masci commented Dec 30, 2019

Hi, thanks for the PR but there's already #530 fixing the same issue. That PR also contains some refactoring I'd like to ship as soon as I can.

@phd
Copy link
Contributor Author

phd commented Dec 30, 2019

Sure.
But I think this could still go in as it makes HardwareDirectories() function consistent.
With #530 ".arduino15" dir should now always exist, but who knows.

Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra details, indeed merging this won't hurt, 👍

@masci masci added this to the 0.7.1 milestone Dec 30, 2019
@masci masci changed the title check if PackagesDir exists when reporting it in HardwareDirectories() [skip changelog] check if PackagesDir exists when reporting it in HardwareDirectories() Dec 30, 2019
@masci masci merged commit d05a742 into arduino:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants