Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the daemon TCP port from config file or command line #513

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Set the daemon TCP port from config file or command line #513

merged 1 commit into from
Dec 13, 2019

Conversation

masci
Copy link
Contributor

@masci masci commented Dec 12, 2019

Let user configure which TCP port to use for the gRPC daemon:

  • from the config file
  • from the command line with --port
  • by setting the env var ARDUINO_DAEMON_PORT

Fixes #485

@masci masci added this to the 0.7.0 milestone Dec 12, 2019
rsora
rsora approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masci masci merged commit 6b047bb into master Dec 13, 2019
@masci masci deleted the massi/daemon-port branch December 13, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

[proposal][feature-request] Make the daemon port configurable
2 participants
@masci @rsora