Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print "multiple libraries found for header.h..." only when it really happens #478

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Print "multiple libraries found for header.h..." only when it really happens #478

merged 1 commit into from
Nov 11, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 11, 2019

Previously printed:

Multiple libraries were found for "DHT.h"
 Used: /home/megabug/Workspace/sketchbook-cores-beta/libraries/DHT_sensor_library
Multiple libraries were found for "Adafruit_Sensor.h"
 Used: /home/megabug/Workspace/sketchbook-cores-beta/libraries/Adafruit_Unified_Sensor
Using library DHT_sensor_library at version 1.3.8 in folder: /home/megabug/Workspace/sketchbook-cores-beta/libraries/DHT_sensor_library 
Using library Adafruit_Unified_Sensor at version 1.0.3 in folder: /home/megabug/Workspace/sketchbook-cores-beta/libraries/Adafruit_Unified_Sensor

Even if there are no multiple libraries available for the particular header. After this patch we have:

Using library DHT_sensor_library at version 1.3.8 in folder: /home/megabug/Workspace/sketchbook-cores-beta/libraries/DHT_sensor_library 
Using library Adafruit_Unified_Sensor at version 1.0.3 in folder: /home/megabug/Workspace/sketchbook-cores-beta/libraries/Adafruit_Unified_Sensor

@cmaglie cmaglie merged commit 37434d1 into arduino:master Nov 11, 2019
@cmaglie cmaglie deleted the reduce-verbosity branch November 11, 2019 12:34
cmaglie added a commit to arduino/arduino-builder that referenced this pull request Nov 11, 2019
@cmaglie
Imported bugfix from upstream
085ed57 
- Auto-disable (deep) caching of core builds if needed
  arduino/arduino-cli#479

- Print "multiple libraries found for header.h" message only when it really happens.
  arduino/arduino-cli#478
@cmaglie cmaglie added this to the 0.7.0 milestone Nov 11, 2019
@per1234 per1234 mentioned this pull request Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

@rsora rsora Awaiting requested review from rsora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @facchinm