Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not try to identify non-usb ports using vid/pid #448

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Do not try to identify non-usb ports using vid/pid #448

merged 2 commits into from
Oct 18, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 18, 2019

No description provided.

@cmaglie cmaglie requested a review from rsora October 18, 2019 10:21
@cmaglie cmaglie force-pushed the cmaglie/do-not-check-api-for-non-usb-ports branch from 9c4bd5e to 5e1add9 Compare October 18, 2019 10:29
@cmaglie cmaglie mentioned this pull request Oct 18, 2019
Closed
@cmaglie cmaglie force-pushed the cmaglie/do-not-check-api-for-non-usb-ports branch from f0209c1 to ca2b84e Compare October 18, 2019 14:42
@cmaglie cmaglie added this to the 0.6.0 milestone Oct 18, 2019
rsora
rsora approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rsora rsora merged commit 3a08b07 into master Oct 18, 2019
@rsora rsora deleted the cmaglie/do-not-check-api-for-non-usb-ports branch October 18, 2019 14:53
@cmaglie cmaglie changed the title Do not try to identify non-usb ports via vid/pid Do not try to identify non-usb ports using vid/pid Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora