Replace ctx.ToolsDirs with ctx.BuiltInToolsDirs #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ToolsDirs field has been replaced by BuiltInToolsDirs during the big refactoring in the arduino-builder repo. The intention was to remove ToolsDirs once done, but for some reasons I forgot to remove it. This commit completes the transition.
cmaglie
force-pushed
the
fix-builtin-tools-legacy
branch
from
dd9d1d7
to
b677403
Compare
|
@ArduinoBot build this please |
|
✅ Build completed. ⬇️ Linux 64: ⬇️ Linux 32: ⬇️ Linux ARM 32: ⬇️ Linux ARM 64: ⬇️ Windows: ⬇️ OSX: ℹ️ To test this build:
|
cmaglie
added a commit
to cmaglie/arduino-builder
that referenced
this pull request
Sep 26, 2019
This will include the following upstream fixes: arduino/arduino-cli#418 arduino/arduino-cli#422 arduino/arduino-cli#428 arduino/arduino-cli#429
cmaglie
added a commit
to arduino/arduino-builder
that referenced
this pull request
Sep 26, 2019
This will include the following upstream fixes: arduino/arduino-cli#418 arduino/arduino-cli#422 arduino/arduino-cli#428 arduino/arduino-cli#429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ToolsDirs field has been replaced by BuiltInToolsDirs during the big refactoring in the arduino-builder repo.
The intention was to remove ToolsDirs once done, but for some reasons I forgot to remove it.
This commit completes the transition.