Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added library dependency support #351

Merged
merged 12 commits into from
Nov 27, 2019
Merged

Added library dependency support #351

merged 12 commits into from
Nov 27, 2019

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 20, 2019 •
edited
Loading

This is preliminary work to implement library dependencies.

  • updated semver library to handle version constraints
  • json parsing
  • added tests for library index parser
  • added GRPC call LibraryResolveDependencies and implementation
  • CLI commands implementation for install and upgrade

@cmaglie cmaglie self-assigned this Aug 23, 2019
@rsora rsora added the status: in progress Work is in progress on this label Sep 3, 2019
@cmaglie cmaglie removed the status: in progress Work is in progress on this label Sep 23, 2019
@cmaglie cmaglie force-pushed the lib-deps branch 2 times, most recently from 52a962f to c204c01 Compare October 2, 2019 20:27
@rsora
Copy link
Contributor

rsora commented Nov 27, 2019

This PR leverages the go.bug.st/relaxed-semver module

This is the first related PR bugst/relaxed-semver#3

This is the state of the art of the resolver file at the time of merging, after a couple of bugfixes
https://github.com/bugst/relaxed-semver/blob/391e10178d18ddf8f579311f6a8f137be13ec4f5/resolver.go

rsora
rsora approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmaglie cmaglie changed the title Library deps (infrastructure) Added library dependency support Nov 27, 2019
@cmaglie cmaglie merged commit b544181 into arduino:master Nov 27, 2019
@cmaglie cmaglie deleted the lib-deps branch November 27, 2019 13:34
@per1234 per1234 mentioned this pull request Jan 11, 2020
Merged
@cmaglie cmaglie mentioned this pull request Feb 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsora rsora rsora approved these changes

Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @rsora