Run integration tests in isolation #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masci
commented
Jul 23, 2019
| """ | ||
| When ouput is empty, nothing is printed out, no matter the output format | ||
| """ | ||
| result = run_command('lib list') | ||
| assert result.ok | ||
| assert '' == result.stderr | ||
| result = run_command('lib list', '--format json') |
There was a problem hiding this comment.
this was the only function calling run_command with more than one arg, I've merged the two into a single list to match the rest of the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid messing with the filesystem of the user running the tests, execute the suite in a temporary folder that'll be wiped after the tests finish.