Core search/list now return boards in a platform #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
masci
suggested changes
Jul 9, 2019
| @@ -0,0 +1,37 @@ | |||
| package core | |||
There was a problem hiding this comment.
Can you add license and copyright header?
commands/core/core.go
Outdated
|
|
||
| // platformReleaseToRPC converts our internal structure to the RPC structure. | ||
| // Note: this function does not touch the "Installed" field of rpc.Platform as it's not always clear that the | ||
| // platformRelease we're currently converting is actually installed. |
There was a problem hiding this comment.
nit: there's an extra tab at the beginning of this line
| func platformReleaseToRPC(platformRelease *cores.PlatformRelease) *rpc.Platform { | ||
| boards := make([]*rpc.Board, len(platformRelease.Boards)) | ||
| i := 0 | ||
| for _, b := range platformRelease.Boards { |
There was a problem hiding this comment.
let's do comment not relevant since it's a mapfor i, b := range platformRelease.Boards and let range deal with the index increments
There was a problem hiding this comment.
That would be my preferred way, too. Boards is a map[string].. though, thus i would not be numeric index here unfortunately.
There was a problem hiding this comment.
oops my bad, didn't check what's been iterated here, scratch my comment!
| string ID = 1; | ||
| string Version = 2; | ||
| string Name = 3; | ||
| repeated Platform search_output = 1; |
Signed-off-by: Christian Weichel <[email protected]>
masci
approved these changes
Jul 9, 2019
mastrolinux
pushed a commit
that referenced
this pull request
Jul 16, 2019
Signed-off-by: Christian Weichel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the list of boards supported by a platform, as well some more metadata to the response of
Core/ListandCore/Search. Further, does it harmonise the structures used by both operations to de-duplicate conversion code converting from the internal structures to the RPC messages.