-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rearrange protobuf files #251
Conversation
✅ Build completed. ⬇️ Linux 64: ⬇️ Linux 32: ⬇️ Linux ARM: ⬇️ Windows: ⬇️ OSX: ℹ️ To test this build:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* move protobuf definitions under rpc/commands * move commands daemon into commands folder * make client a test case * run protoc as part of the testing pipeline
I've decided to be conservative and reduce the impact of the layout at the bare minimum, we can iterate later should we need to. For now, this PR will:
commands
for now)protoc
, the task is run in the CI to ensure we don't commit wrong.proto
filesdaemon
undercommands
for consistency