Debugger now allows generic selection of sub-configurations #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2435 +/- ##
==========================================
+ Coverage 67.28% 67.38% +0.10%
==========================================
Files 210 210
Lines 20576 20574 -2
==========================================
+ Hits 13844 13864 +20
+ Misses 5593 5575 -18
+ Partials 1139 1135 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
umbynos
reviewed
Nov 23, 2023
| @@ -169,12 +175,10 @@ func getDebugProperties(req *rpc.GetDebugConfigRequest, pme *packagemanager.Expl | |||
| } | |||
| } | |||
|
|
|||
| toolchainPrefix := debugProperties.Get("toolchain.prefix") | |||
| // HOTFIX: for samd (and maybe some other platforms). We should keep this for a reasonable | |||
There was a problem hiding this comment.
This is also for other cores like the esp32 one
There was a problem hiding this comment.
The comment says:
for samd (and maybe some other platforms)
esp32 is some other platform :-)
cmaglie
added
type: enhancement
umbynos
approved these changes
Nov 24, 2023
6 tasks
cmaglie
added a commit
to cmaglie/arduino-cli
that referenced
this pull request
Dec 20, 2023
…2435) * debug: extend hotfix for trailing dash '-' to all toolchains * Added additional_config selector for debug configuration * Added docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
It is now possible to use any sub-tree of the platform configuration to override the debugger configuration using the directive
debug.additional_config=CONF_PREFIX.This change allows a more convenient rationalization and selection of the configs to apply. For example, we could factor common parts of a configuration in the
platform.txtfile:and choose to add the right configuration depending on the board in the boards.txt file:
Another possibility is to compose the configuration using another variable present in the board configuration, for example if in the platform.txt we add:
we may use the
build.mcuvalue as a "selector" for the board-specific debug configuration that is added to the global debug configuration:What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information