Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "config get" command to print settings values #2307

Merged
merged 10 commits into from
Feb 14, 2024
Merged

add "config get" command to print settings values #2307

merged 10 commits into from
Feb 14, 2024

Commits on Feb 8, 2024

  1. add "config get" command to print settings values

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f3bf168 View commit details
    Browse the repository at this point in the history

  2. use RPC for "config get" and add test cases

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    76eca4d View commit details
    Browse the repository at this point in the history

  3. update imports for changed internal layout

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    e5f0881 View commit details
    Browse the repository at this point in the history

  4. config/get: do not wrap JSON output in YAML

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    926d850 View commit details
    Browse the repository at this point in the history

  5. fix formatting with gofmt

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6efcca6 View commit details
    Browse the repository at this point in the history

  6. config/get: unmarshal JSON RPC response

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    d67f3d7 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Cristian Maglie <[email protected]>
    @ardnew @cmaglie
    ardnew and cmaglie committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ba04e61 View commit details
    Browse the repository at this point in the history

  8. use same default format as "config dump"

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    c069ece View commit details
    Browse the repository at this point in the history

  9. fix import missing after merging review changes remotely

    @ardnew
    ardnew committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6e5be88 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. test (config): fix expected error message with "get <unknown-key>"

    @ardnew
    ardnew committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    2942031 View commit details
    Browse the repository at this point in the history