Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Added gRPC close signal to Monitor call (allows graceful close of monitor) #2276

Merged
merged 9 commits into from
Jan 2, 2024
Merged

feature: Added gRPC close signal to Monitor call (allows graceful close of monitor) #2276

merged 9 commits into from
Jan 2, 2024

Commits on Jan 2, 2024

  1. Refactored gRPC Monitor API

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    bf067ea View commit details
    Browse the repository at this point in the history

  2. Added Close request to gRPC Monitor API

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    9c59c34 View commit details
    Browse the repository at this point in the history

  3. Updated docs

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    86cb04f View commit details
    Browse the repository at this point in the history

  4. Made CreateEnvForDaeamon available in all integration tests

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    5a39d1c View commit details
    Browse the repository at this point in the history

  5. Added integration test

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    62f3f1b View commit details
    Browse the repository at this point in the history

  6. lint: avoid redefinition of the built-in function close

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    2cf3f8f View commit details
    Browse the repository at this point in the history

  7. lint: comparing with == will fail on wrapped errors. Use errors.Is to… 

    … check for a specific error
    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    3fd0bad View commit details
    Browse the repository at this point in the history

  8. Allow up to 5 seconds for a pluggable monitor to gracefully close

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    f2a023a View commit details
    Browse the repository at this point in the history

  9. Made the gRPC daemon actually wait for port close completion

    @cmaglie
    cmaglie committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    094e3a5 View commit details
    Browse the repository at this point in the history