[breaking] Simplified gRPC streams helpers #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
- Coverage 36.58% 36.58% -0.01%
==========================================
Files 231 231
Lines 19561 19564 +3
==========================================
Hits 7157 7157
- Misses 11578 11581 +3
Partials 826 826
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cmaglie
added
type: enhancement
per1234
approved these changes
Sep 2, 2022
cmaglie
changed the title
cmaglie
force-pushed
the
simplify_grpc_streams
branch
from
405a810
to
d3efd13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Simplifies the gRPC streams helpers: the
Closemethod on theWriteCloserobject, returned by the functionFeedStreamTo, is now synchronized with the other side of the "pipe" and automatically waits for the messages to be flushed., there is no more need to explicitly wait.What is the current behavior?
In theory, there should be no change in behavior.
What is the new behavior?
In practice, this PR may solve some very well hidden bugs.
Does this PR introduce a breaking change, and is titled accordingly?
Yes. The functions
utils.FeedStreamToandutils.ConsumeStreamFromare now private.