Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --no-overwrite flag in core install #1794

Merged
merged 7 commits into from
Jul 11, 2022

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Jul 8, 2022

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?
Adds a --no-overwrite flag in core install. When set, the platforms already installed won't be touched by the installer (no upgrades/downgrades)

What is the current behavior?
The installation will always proceed.

What is the new behavior?
Installation is aborted if --no-overwrite is set and the newly installed platform will replace the installed one.

Does this PR introduce a breaking change, and is titled accordingly?
No

@cmaglie cmaglie requested a review from a team July 8, 2022 13:01
@cmaglie cmaglie self-assigned this Jul 8, 2022
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Jul 8, 2022
cli/core/install.go Outdated Show resolved Hide resolved
rpc/cc/arduino/cli/commands/v1/core.proto Outdated Show resolved Hide resolved
@cmaglie cmaglie force-pushed the add_no_overwrite_in_core_install branch from 08a5f3d to 858887f Compare July 11, 2022 08:24
@cmaglie cmaglie merged commit ffe4232 into arduino:master Jul 11, 2022
@cmaglie cmaglie deleted the add_no_overwrite_in_core_install branch July 11, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants