Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolution of library names when checking for upgrades #1725

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix resolution of library names when checking for upgrades #1725

merged 1 commit into from
May 11, 2022

Commits on May 9, 2022

  1. Use real names for libs in upgrade commands 

    The real name for a lib (the name stored in the library.properties)
is required to find a library in the index. The installed name, which
matches the diretory name, is not valid for looking up libraries in
the index.

Libraries that do not have a library.properties file, or where the
name value in that file does not match the value in library_index.json,
cannot be upgrade by the CLI.

Also Fix tests for outdated libs

The tests for update and outdated changed the library.properties
file for an installed lib, but also wiped out the name field.
Since we rely on that field to determine the library name when
using the RealName property, the test's change was causing a failure
outside the scope of the test itself.
    @stonehippo
    stonehippo committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d4d1fa9 View commit details
    Browse the repository at this point in the history