Fix installation script bugs affecting Apple M1 users #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script which provides convenient installation of Arduino CLI is hosted and maintained in a separate repository which contains the collection of reusable tooling project assets. Some defects were present in the script's handling of lack of a build for a specific host architecture, which manifested when users with Apple M1 systems attempted to use it. These defects were fixed and some general improvements made to the related code. - Remove broken frivolous function from install script arduino/tooling-project-assets@127116b - Remove unnecessary use of eval from install script arduino/tooling-project-assets@e2b5740 - Fallback to x86-64 release when macOS ARM 64-bit build not available arduino/tooling-project-assets@d8c59e3 Those are pulled into the Arduino CLI project here.
per1234
added
os: macos
umbynos
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
(testing is done in the assets repo, but they were not updated there due to the lack of an M1 runner
Docs have been added / updated (for bug fixes / features)UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Bug fix
What is the current behavior?
An installation script contained in this repository provides convenient installation of Arduino CLI:
https://arduino.github.io/arduino-cli/dev/installation/#use-the-install-script
Some defects are present in the script's handling of lack of a build for a specific host architecture, which manifested when users with Apple M1 systems attempted to use it:
What is the new behavior?
The script is hosted and maintained in a separate repository as part of a collection of reusable tooling project assets.
The defects in the script were fixed, and some general improvements made to the related code, in that repository:
arduino/tooling-project-assets@127116b
evalfrom install scriptarduino/tooling-project-assets@e2b5740
arduino/tooling-project-assets@d8c59e3
Those are pulled into the Arduino CLI project here.
Does this PR introduce a breaking change, and is titled accordingly?
No breaking change