Discoveries are now closed and unregistered after failure #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
type: enhancement
silvanocerza
force-pushed
the
scerza/strenghten-discovery
branch
from
f0cff2c
to
ec9c277
Compare
silvanocerza
changed the title
board list now returns partial results in case of errors
silvanocerza
force-pushed
the
scerza/strenghten-discovery
branch
from
ec9c277
to
2ee4cef
Compare
silvanocerza
added
topic: code
silvanocerza
force-pushed
the
scerza/strenghten-discovery
branch
3 times, most recently
from
babb858
to
84c454a
Compare
silvanocerza
force-pushed
the
scerza/strenghten-discovery
branch
from
84c454a
to
8064d10
Compare
cmaglie
approved these changes
Feb 17, 2022
silvanocerza
added a commit
that referenced
this pull request
Feb 23, 2022
* Discoveries are now closed and unregistered after failure * Add mutex to guard discoveries in DiscoveryManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Enhances internal handling of pluggable discoveries.
If sending a command to a discovery returns an error its process is left running, this often causes subsequent commands to fail.
If sending a command to a discovery returns an error now its process is killed and the discovery removed from the list of running discoveries.
titled accordingly?
Nope.
None.
See how to contribute