-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample command to solve compile or upload issue is now shown to CLI users #1647
Conversation
cli/compile/compile.go
Outdated
@@ -264,6 +269,28 @@ func runCompileCommand(cmd *cobra.Command, args []string) { | |||
}) | |||
if compileError != nil && output.OutputFormat != "json" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the added logic happens if output.OutputFormat != "json"
, this means that no error is returned in case the output is json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very helpful enhancement.
Thanks Silvano!
Link check workflows are failing again, it's a false positive as usual. Merging anyway. Thanks @per1234. <3 |
Please check if the PR fulfills these requirements
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)Enhances certain error messages of
compile
andupload
commands.titled accordingly?
Nope.
Closes #1356.
See how to contribute