Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML to feedback formats #1600

Merged
merged 2 commits into from
Dec 20, 2021
Merged

Conversation

polldo
Copy link
Contributor

@polldo polldo commented Dec 20, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

This pr enhances the feedback package by allowing to use also the YAML format.
For the YAML marshal It's been selected a YAML dependency already present in go.mod

  • What is the current behavior?
  • What is the new behavior?
  • Other information:

See how to contribute

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2021

CLA assistant check
All committers have signed the CLA.

@umbynos
Copy link
Contributor

umbynos commented Dec 20, 2021

Maybe could be useful to have also the completion for yaml?

validOutputFormats := []string{"text", "json", "jsonmini"}

@polldo
Copy link
Contributor Author

polldo commented Dec 20, 2021

the goal of this pr was just to improve the feedback package, without actually enable YAML support in arduino-cli (I don't know if you want this feature, we need it in the cloud-cli for extracting cloud templates from things and dashboards)

If you'd like arduino-cli to support yaml format I can make the necessary changes, just let me know 😄

@silvanocerza
Copy link
Contributor

the goal of this pr was just to improve the feedback package, without actually enable YAML support in arduino-cli (I don't know if you want this feature, we need it in the cloud-cli for extracting cloud templates from things and dashboards)

If you'd like arduino-cli to support yaml format I can make the necessary changes, just let me know smile

Please do. 😄

@polldo
Copy link
Contributor Author

polldo commented Dec 20, 2021

Updated!

Copy link
Contributor

@silvanocerza silvanocerza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, good job! 👍

Feel free to merge as soon all checks pass.

The links check workflow is failing cause gnu.org seems down, ignore it.

@polldo polldo merged commit 5dd14c4 into arduino:master Dec 20, 2021
@per1234 per1234 added topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement labels Jan 15, 2022
@cmaglie cmaglie mentioned this pull request Apr 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants