Fix panic when discovery doesn't send an ok message after a command #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
added
topic: code
cmaglie
approved these changes
Nov 25, 2021
umbynos
approved these changes
Nov 25, 2021
silvanocerza
force-pushed
the
scerza/fix-discoveries-panic
branch
from
0f13d98
to
708324d
Compare
umbynos
pushed a commit
that referenced
this pull request
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)Bug fixing.
If the user has installed a core that comes with a pluggable discovery that doesn't send an
okmessage after a discovery command is received thearduino-climight panic when running some commands.The
arduino-clidoesn't panic anymore but just logs the error if a discovery doesn't send anokmessage after receiving a discovery command.titled accordingly?
Nope.
None.
See how to contribute