Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to go 1.17.8 #1567

Merged
merged 4 commits into from
Mar 14, 2022
Merged

Bump go version to go 1.17.8 #1567

merged 4 commits into from
Mar 14, 2022

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Nov 24, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Update go version used

  • What is the current behavior?

We currently use go 1.16.4

  • What is the new behavior?

We currently use go 1.17.8

nope

  • Other information:

See how to contribute

@umbynos umbynos added the topic: infrastructure Related to project infrastructure label Nov 24, 2021
@umbynos umbynos requested a review from a team November 24, 2021 10:14
@umbynos umbynos self-assigned this Nov 24, 2021
@umbynos
Copy link
Contributor Author

umbynos commented Nov 24, 2021

I have run the tests locally on linux and it seems there are no regressions with go 1.17

@rsora
Copy link
Contributor

rsora commented Nov 24, 2021

Let's be cautious on this one, I would wait for other tasks to be closed, and also to dig a bit more with testing 🔎

@umbynos
Copy link
Contributor Author

umbynos commented Nov 24, 2021

BTW @silvanocerza finished running local tests on macOS and everything went smooth

@umbynos
Copy link
Contributor Author

umbynos commented Nov 25, 2021

Note for future self: The homebrew version is built with go 1.17 (and not pinned) since 0.20.0 Homebrew/homebrew-core#89858

@silvanocerza
Copy link
Contributor

@rsora @umbynos I think we can merge this, I have been building the arduino-cli with Go 1.17 since it came out and never had any issue connected to it.

@umbynos umbynos force-pushed the umbynos/bump_go branch 2 times, most recently from b1a12d4 to 99d2141 Compare March 14, 2022 08:50
DistTasks.yml Outdated Show resolved Hide resolved
@per1234 per1234 added the type: enhancement Proposed improvement label Mar 14, 2022
@umbynos umbynos changed the title Bump go version we use to build and release to go 1.17.3 Bump go version to go 1.17.8 Mar 14, 2022
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umbynos umbynos merged commit ae57066 into master Mar 14, 2022
@umbynos umbynos deleted the umbynos/bump_go branch March 14, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants