Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance handling of colored output #1418

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Conversation

silvanocerza
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Enhances commands output.

  • What is the current behavior?

Colored output on Windows Powershell and Command Prompt is not handled correctly and output is mangled with escape characters.

Also users have no way of disabling colored output if necessary.

  • What is the new behavior?

Colored output now works correctly on Windows Powershell and Command Prompt and users can easily disable colored output in different ways:

  • Using the NO_COLOR env var (https://no-color.org/)
  • Using the output.no_color config setting or related env var OUTPUT_NO_COLOR
  • Using the --no-color flag

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza requested a review from a team August 30, 2021 13:09
@silvanocerza silvanocerza self-assigned this Aug 30, 2021
@silvanocerza silvanocerza force-pushed the scerza/fix-colored-output branch 2 times, most recently from 2c78664 to d770e19 Compare August 30, 2021 13:14
@silvanocerza silvanocerza force-pushed the scerza/fix-colored-output branch 2 times, most recently from d57dbaa to ce1ca02 Compare August 30, 2021 13:31
@silvanocerza silvanocerza merged commit ff4eb92 into master Aug 30, 2021
@silvanocerza silvanocerza deleted the scerza/fix-colored-output branch August 30, 2021 14:26
@rsora rsora added the topic: CLI Related to the command line interface label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: CLI Related to the command line interface type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants